Rails 5 #502
Merged
Rails 5 #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size (2147483647) given to the type 'nvarchar' exceeds the maximum allowed for any data type (8000).
* Dont worry about view info cache. Since product of columns is cached. * May have to not care about a few schema tests later down the road.
| SQLSERVER_STATEMENT_PREFIX = 'EXEC sp_executesql ' | ||
| SQLSERVER_PARAM_MATCHER = /@\d+ =/ | ||
| SQLSERVER_STATEMENT_PREFIX = 'EXEC sp_executesql '.freeze | ||
| SQLSERVER_PARAM_MATCHER = /@\d+ = (.*)/.freeze |
There was a problem hiding this comment.
Regex literals are always frozen in Ruby.
Member
Author
There was a problem hiding this comment.
Thanks... keep it coming :)
|
#RandomUnsolicedCodeReview |
| def view_exists?(table_name) | ||
| identifier = SQLServer::Utils.extract_identifiers(table_name) | ||
| views.include? identifier.object | ||
| end |
There was a problem hiding this comment.
Does the identifier need to be stored in memory?
From
identifier = SQLServer::Utils.extract_identifiers(table_name)
views.include? identifier.object
to
views.include? SQLServer::Utils.extract_identifiers(table_name).object
For a one liner that doesn't stamp out memory. Since it is only used once.
|
Yay merge! |
Member
Author
NOTICEPlease keep in mind this is only the core adapter tests passing. I'll be making individual PRs as work progresses for other things. There is still much work to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will be squashed and merged when complete. For now, we just got the adapter tests passing. I have yet to run the full ActiveRecord suite to see what else needs to be done but I suspect it will take a few more weeks till we are ready for a pre-release and testing.